Skip to content

Fix Nitro React Router platform output#2930

Draft
NathanColosimo wants to merge 4 commits into
mainfrom
codex/fix-nitro-react-router-platform-output
Draft

Fix Nitro React Router platform output#2930
NathanColosimo wants to merge 4 commits into
mainfrom
codex/fix-nitro-react-router-platform-output

Conversation

@NathanColosimo

@NathanColosimo NathanColosimo commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes the React Router + Nitro setup added in #2908.

  • Keeps Nitro's preset output directories, including .vercel/output on Vercel.
  • Copies React Router's client manifest back to the path React Router expects.

Verified locally and with the Vercel preset using Workflow v4 and v5, React Router v8, and Nitro v3. Both production builds exit without a process-global esbuild shutdown.

Docs Preview

v5 page Preview
Overview React Router
React Router v7 Guide
React Router v8 Guide

Refs #821 and #2924.

@vercel

vercel Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Jul 15, 2026 2:21am
example-nextjs-workflow-webpack Ready Ready Preview, Comment Jul 15, 2026 2:21am
example-workflow Ready Ready Preview, Comment Jul 15, 2026 2:21am
workbench-astro-workflow Ready Ready Preview, Comment Jul 15, 2026 2:21am
workbench-express-workflow Ready Ready Preview, Comment Jul 15, 2026 2:21am
workbench-fastify-workflow Ready Ready Preview, Comment Jul 15, 2026 2:21am
workbench-hono-workflow Ready Ready Preview, Comment Jul 15, 2026 2:21am
workbench-nitro-workflow Ready Ready Preview, Comment Jul 15, 2026 2:21am
workbench-nuxt-workflow Ready Ready Preview, Comment Jul 15, 2026 2:21am
workbench-sveltekit-workflow Ready Ready Preview, Comment Jul 15, 2026 2:21am
workbench-tanstack-start-workflow Ready Ready Preview, Comment Jul 15, 2026 2:21am
workbench-vite-workflow Ready Ready Preview, Comment Jul 15, 2026 2:21am
workflow-docs Ready Ready Preview, Comment, Open in v0 Jul 15, 2026 2:21am
workflow-swc-playground Ready Ready Preview, Comment Jul 15, 2026 2:21am
workflow-tarballs Ready Ready Preview, Comment Jul 15, 2026 2:21am
workflow-web Ready Ready Preview, Comment Jul 15, 2026 2:21am

@changeset-bot

changeset-bot Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0af1610

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

✅ All tests passed

Summary

Passed Failed Skipped Total
✅ ▲ Vercel Production 1453 0 230 1683
✅ 💻 Local Development 1617 0 219 1836
✅ 📦 Local Production 1617 0 219 1836
✅ 🐘 Local Postgres 1617 0 219 1836
✅ 🪟 Windows 153 0 0 153
✅ 📋 Other 894 0 177 1071
✅ vercel-multi-region 27 0 0 27
Total 7378 0 1064 8442

Details by Category

✅ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 126 0 27
✅ example 126 0 27
✅ express 126 0 27
✅ fastify 126 0 27
✅ hono 126 0 27
✅ nextjs-turbopack 150 0 3
✅ nextjs-webpack 150 0 3
✅ nitro 126 0 27
✅ nuxt 126 0 27
✅ sveltekit 145 0 8
✅ vite 126 0 27
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 128 0 25
✅ express-stable 128 0 25
✅ fastify-stable 128 0 25
✅ hono-stable 128 0 25
✅ nextjs-turbopack-canary 134 0 19
✅ nextjs-turbopack-stable 153 0 0
✅ nextjs-webpack-canary 134 0 19
✅ nextjs-webpack-stable 153 0 0
✅ nitro-stable 128 0 25
✅ nuxt-stable 128 0 25
✅ sveltekit-stable 147 0 6
✅ vite-stable 128 0 25
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 128 0 25
✅ express-stable 128 0 25
✅ fastify-stable 128 0 25
✅ hono-stable 128 0 25
✅ nextjs-turbopack-canary 134 0 19
✅ nextjs-turbopack-stable 153 0 0
✅ nextjs-webpack-canary 134 0 19
✅ nextjs-webpack-stable 153 0 0
✅ nitro-stable 128 0 25
✅ nuxt-stable 128 0 25
✅ sveltekit-stable 147 0 6
✅ vite-stable 128 0 25
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 128 0 25
✅ express-stable 128 0 25
✅ fastify-stable 128 0 25
✅ hono-stable 128 0 25
✅ nextjs-turbopack-canary 134 0 19
✅ nextjs-turbopack-stable 153 0 0
✅ nextjs-webpack-canary 134 0 19
✅ nextjs-webpack-stable 153 0 0
✅ nitro-stable 128 0 25
✅ nuxt-stable 128 0 25
✅ sveltekit-stable 147 0 6
✅ vite-stable 128 0 25
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 153 0 0
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 128 0 25
✅ e2e-local-dev-tanstack-start- 128 0 25
✅ e2e-local-postgres-nest-stable 128 0 25
✅ e2e-local-postgres-tanstack-start- 128 0 25
✅ e2e-local-prod-nest-stable 128 0 25
✅ e2e-local-prod-tanstack-start- 128 0 25
✅ e2e-vercel-prod-tanstack-start 126 0 27
✅ vercel-multi-region
App Passed Failed Skipped
✅ nextjs-turbopack 27 0 0

📋 View full workflow run

@github-actions

github-actions Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 39117e8 · Tue, 14 Jul 2026 23:29:37 GMT · run logs

Backend: vercel · app: nextjs-turbopack

Metric Scenario Avg (ms) P75 (ms) P90 (ms) P99 (ms) Samples
TTFS stream 1440 (+4.5%) 1752 🔴 1820 🔴 1961 🔴 30
TTFS hook + stream 1571 (+15%) 1963 🔴 2019 🔴 2251 🔴 30
STSO 1020 steps (1-20) 283 (-5.6%) 305 🔴 413 🔴 454 🔴 19
STSO 1020 steps (101-120) 438 (+0.9%) 488 🔴 615 🔴 624 🔴 19
STSO 1020 steps (1001-1020) 937 (+3.9%) 978 🔴 1068 🔴 1166 🔴 19
WO stream 1440 (+4.5%) 1752 1820 1961 30
WO hook + stream 1571 (+15%) 1963 2019 2251 30
SL stream 4251 (-15%) 4869 🔴 5392 🔴 5826 🔴 30
SL hook + stream 4978 (-1.2%) 5519 🔴 5674 🔴 5899 🔴 30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@NathanColosimo NathanColosimo mentioned this pull request Jul 14, 2026
Open
@NathanColosimo
remove unnecessary esbuild service shutdown
f446c76 
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@NathanColosimo
Merge remote-tracking branch 'origin/main' into codex/fix-nitro-react…
a83d7ba 
…-router-platform-output
@NathanColosimo
remove obsolete Nitro hook mock
0af1610 
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijjk ijjk Awaiting requested review from ijjk ijjk will be requested when the pull request is marked ready for review ijjk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NathanColosimo